Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

client: raise NotFound exception on 404 #83

Merged
merged 2 commits into from
Jan 14, 2021
Merged

client: raise NotFound exception on 404 #83

merged 2 commits into from
Jan 14, 2021

Conversation

oscnord
Copy link
Contributor

@oscnord oscnord commented Jan 12, 2021

Client should raise a NotFound exception for status code 404.

@oscnord
raise NotFound exception on 404
045af9c 
Raise a NotFound exception for status code 404.
@oscnord oscnord marked this pull request as ready for review January 13, 2021 14:06
igorsobreira
igorsobreira reviewed Jan 14, 2021
View reviewed changes
@rafaelcaricio rafaelcaricio merged commit 7b9f6e4 into cbsinteractive:master Jan 14, 2021
@oscnord oscnord deleted the raise-notfound-exception branch May 4, 2021 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@igorsobreira igorsobreira igorsobreira approved these changes

@rafaelcaricio rafaelcaricio rafaelcaricio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oscnord @igorsobreira @rafaelcaricio