fix: typescript declarations for Slider and SliderSkeleton #20833
+8
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those components do not have a property named "propTypes", but the declarations in Slider.d.ts and Slider.Skeleton.d.ts claimed they did. I think the problem happens because there's some magic that tries to generate Typescript declarations based on the PropTypes, and that is fragile. I followed the example of Row.tsx to avoid / workaround that issue. Fixes carbon-design-system#20832.
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20833 +/- ##
==========================================
- Coverage 92.35% 92.32% -0.03%
==========================================
Files 511 511
Lines 37247 37247
Branches 5726 5669 -57
==========================================
- Hits 34398 34388 -10
- Misses 2700 2711 +11
+ Partials 149 148 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@adamalston - You may want to review this as the problem started with your #20329 (although Slider's typescript declarations before your PR were also broken, but in a different way). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20832.
Fix Typescript declarations for Slider and SliderSkeleton.
Those components do not have a property named "propTypes", but the declarations in Slider.d.ts and Slider.Skeleton.d.ts claimed they did.
I think the problem happens because there's some magic that tries to generate Typescript declarations based on the PropTypes, and that is fragile. I followed the example of Row.tsx to avoid / workaround that issue.
Changelog
Changed
Testing / Reviewing
Built my application without any Typescript errors.
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide