-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: issue 20774 Border on selected list item on dropdown #20779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for contributing!! Your contribution is appreciated.
This looks good!
One minor suggestion: consider using border-block-start: none instead of border-block-start: 0 to stay consistent with other border declarations in the Carbon codebase.
|
Please comment "I have read the DCO document and I hereby sign the DCO." for DCO to pass. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20779 +/- ##
=======================================
Coverage 92.46% 92.46%
=======================================
Files 508 508
Lines 35753 35753
Branches 5673 5673
=======================================
Hits 33058 33058
Misses 2550 2550
Partials 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Question for @thyhmdo: In ComboBox, focus remains fixed on the selected item when opened Are these behaviors intentionally different, or should they be consistent? The documentation doesn't seem to clarify which approach is correct according to design system guidelines. Could you provide guidance? |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
|
@riddhybansal Was my last commit ok to continue? |
Closes #20774
fix: issue #20774 -> Border on selected list item on dropdown
Changelog
New
Changed
Removed
Testing / Reviewing
Open Dropdown and select an item
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request guide