Skip to content

Conversation

@sbriones97
Copy link

@sbriones97 sbriones97 commented Oct 22, 2025

Closes #20774

fix: issue #20774 -> Border on selected list item on dropdown

Changelog

New

  • Css property for active selected item on list

Changed

  • border start 0

Removed

  • N/A

Testing / Reviewing

Open Dropdown and select an item

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@sbriones97 sbriones97 requested a review from a team as a code owner October 22, 2025 17:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2025

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b3a52ed
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/690092760bd5b20008f3f7e2
😎 Deploy Preview https://deploy-preview-20779--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b3a52ed
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/69009276c38d050008403227
😎 Deploy Preview https://deploy-preview-20779--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for contributing!! Your contribution is appreciated.
This looks good!
One minor suggestion: consider using border-block-start: none instead of border-block-start: 0 to stay consistent with other border declarations in the Carbon codebase.

@riddhybansal
Copy link
Contributor

Please comment "I have read the DCO document and I hereby sign the DCO." for DCO to pass.

@netlify
Copy link

netlify bot commented Oct 23, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b3a52ed
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/690092766b064f0008b55149
😎 Deploy Preview https://deploy-preview-20779--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.46%. Comparing base (84b09fc) to head (b3a52ed).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20779   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files         508      508           
  Lines       35753    35753           
  Branches     5673     5673           
=======================================
  Hits        33058    33058           
  Misses       2550     2550           
  Partials      145      145           
Flag Coverage Δ
main-packages 85.49% <ø> (ø)
web-components 97.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@riddhybansal
Copy link
Contributor

Question for @thyhmdo:
I notice different focus behaviors between Dropdown and ComboBox:

In ComboBox, focus remains fixed on the selected item when opened
In Dropdown, focus moves with the mouse cursor and loses focus from options if the cursor isn't over any option (only hover state changes)

Are these behaviors intentionally different, or should they be consistent? The documentation doesn't seem to clarify which approach is correct according to design system guidelines. Could you provide guidance?

@sbriones97
Copy link
Author

I have read the DCO document and I hereby sign the DCO.

@sbriones97
Copy link
Author

recheck

@sbriones97
Copy link
Author

@riddhybansal Was my last commit ok to continue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dropdown selector shows unexpected border on selected item

2 participants