Make SStream respect the CS_OPT_UNSIGNED flag. #2723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CS_OPT_UNSIGNED flag could be set but was ignored by SStream. Since most refactored architecture modules use the SStream API they effectively ignored the CS_OPT_UNSIGNED flag as well. Here we check it in the SStream and redirect to the corresponding unsigned function if set.
|
cc @jiegec |
|
Great, that is an elegant way to accomplish this. I was thinking about adding the logic to all archs manually, which is tedious. |
Yeah, I think this was also the old way. But |
kabeor
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
The CS_OPT_UNSIGNED flag could be set but was ignored by SStream. Since most refactored architecture modules use the SStream API they effectively ignored the CS_OPT_UNSIGNED flag as well.
Here we check it in the SStream and redirect to the corresponding unsigned function if set.
Test plan
Added
Closing issues
closes #2722