Skip to content

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented May 20, 2025

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

  • Updates the API from tree-sitter-py to 24.0

Waiting for comment on tree-sitter/py-tree-sitter#350

Test plan

All green

Closing issues

closes #2459

@github-actions github-actions bot added the Auto-Sync-files Auto-Sync label May 20, 2025
@Rot127 Rot127 marked this pull request as ready for review June 10, 2025 12:26
@Rot127
Copy link
Collaborator Author

Rot127 commented Jun 10, 2025

I could not reproduce the segfault with Python 3.13. Only with Python 3.12. I am not sure if we should merge this without this segfault being fixed. Probably not. We would need to fix the version to 3.13 then.

But the code is ready for review.

@jiegec
Copy link
Collaborator

jiegec commented Jun 15, 2025

I could not reproduce the segfault with Python 3.13. Only with Python 3.12. I am not sure if we should merge this without this segfault being fixed. Probably not. We would need to fix the version to 3.13 then.

But the code is ready for review.

How can I reproduce the segfault? I can investigate this.

@notxvilka
Copy link

I could not reproduce the segfault with Python 3.13. Only with Python 3.12. I am not sure if we should merge this without this segfault being fixed. Probably not. We would need to fix the version to 3.13 then.
But the code is ready for review.

How can I reproduce the segfault? I can investigate this.

See tree-sitter/py-tree-sitter#350 (comment)

@Rot127 Rot127 merged commit 5af2880 into capstone-engine:next Jun 26, 2025
22 checks passed
@Rot127 Rot127 deleted the py13-update branch June 26, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump tree_sitter past 0.22

3 participants