Skip to content

Conversation

@kraenhansen
Copy link
Collaborator

Merging this PR will:

  • Ensure the Ferric build tool fails with a non-zero exit code on usage and spawn errors.

@kraenhansen kraenhansen self-assigned this Jun 19, 2025
@kraenhansen kraenhansen added bug Something isn't working Ferric 🦀 labels Jun 19, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2025

⚠️ No Changeset found

Latest commit: cfb7b30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kraenhansen kraenhansen requested a review from Copilot June 19, 2025 20:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Ferric build tool to set a non-zero exit code when an error occurs during command execution.

  • Adds process.exitCode = 1 in the error handler to signal failure.
  • Retains existing behavior for flushing spawn errors.

@kraenhansen kraenhansen merged commit 04545b8 into main Jun 19, 2025
4 checks passed
@kraenhansen kraenhansen deleted the kh/ferric/non-zero-exit-code branch June 19, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Ferric 🦀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants