Add bootstrap scripts
#120
Conversation
|
|
|
||
| // Clean up the destination directory before copying | ||
| fs.rmSync(EXAMPLES_DIR, { recursive: true, force: true }); | ||
| // fs.rmSync(EXAMPLES_DIR, { recursive: true, force: true }); |
There was a problem hiding this comment.
did you mean to leave this commented out line in?
There was a problem hiding this comment.
Yeah. I might regret that, but for now it seems most appropriate. It does mean that someone disabling an example above would have to manually delete the dir, but the benefit is that we're not nuking the build directories.
| "lint": "eslint .", | ||
| "test": "npm run test --workspace react-native-node-api --workspace cmake-rn --workspace gyp-to-cmake --workspace node-addon-examples" | ||
| "test": "npm run test --workspace react-native-node-api --workspace cmake-rn --workspace gyp-to-cmake --workspace node-addon-examples", | ||
| "bootstrap": "npm run build && npm run bootstrap --workspaces --if-present" |
There was a problem hiding this comment.
can you add npm run bootstrap in the multi-platform CI?
There was a problem hiding this comment.
Yes, once #118 merge I believe.
I will do that in a follow-up PR.
|
Merging for now, to keep things going. Please review in retrospect. |
Instead of adding Nx (see #51) - it seems we can keep things simple and have a single "bootstrap" script in the root to build and bootstrap things in sequence.