Skip to content

fix: fix building generated project on ios #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2020
Merged

fix: fix building generated project on ios #43

merged 3 commits into from
May 7, 2020

Conversation

@mateosilguero
Copy link
Contributor

@mateosilguero mateosilguero commented May 6, 2020

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@mateosilguero mateosilguero mentioned this pull request May 6, 2020
Merged
5 tasks
@satya164
Copy link
Member

satya164 commented May 7, 2020

Thanks!

@satya164 satya164 changed the title Fix/ios build fix: fix building generated project on ios May 7, 2020
@satya164 satya164 merged commit 15579f4 into callstack:master May 7, 2020
satya164 pushed a commit that referenced this pull request May 7, 2020
@mateosilguero @satya164
fix: fix building generated project on ios (#43)
b681c8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mateosilguero @satya164