Skip to content

Conversation

@jbtheard
Copy link
Contributor

@jbtheard jbtheard commented Apr 3, 2020

Summary

Executing

pod install

currently results in pod complaining no pod spec exists for react-native-bob

This fix tentatively add a react-native-bob.podspec file that should solve this.

Note: this new file should be published at the root of the package. I'm not quite sure how this can be done. Please edit accordingly.

We also add a homepage property in package.json as it's required by standard podspec files

Test Plan

When file manually added to node_module/@react-native-community/bob, executing pod install doesn't complain anymore

What's required for testing (prerequisites)?

Not quite sure how to test before releasing a new version ?

Compatibility

OS Implemented
iOS
Android n/a

Checklist

  • [X ] I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

A root podspec file should be published with package so that pod install doesn't complain when installing projects with bob.

I add it here but not quite sure where it should be in order to be published at the root of package.

Also added homepage property in package.json as required by podspec.
@satya164
Copy link
Member

satya164 commented Apr 3, 2020

Hmm, why would you need a podspec? This is not a native module. Seems like a bug in CLI?

@thymikee
Copy link
Member

thymikee commented Apr 3, 2020

Hey! It seems like CLI is detecting Bob as native library. It should be possible to disable autolinking of this package by creating a react-native.config.js in the root of Bob package. Here's some documentation around the topic: https://github.com/react-native-community/cli/blob/master/docs/dependencies.md

@jbtheard
Copy link
Contributor Author

jbtheard commented Apr 6, 2020

react-native.config.js file added as per @thymikee 's suggestion

@thymikee thymikee requested a review from satya164 April 6, 2020 07:31
@satya164 satya164 changed the title fix: add podspec so that pod install doesnt complain fix: add rn-config so CLI doesn't try to link it May 6, 2020
@satya164 satya164 merged commit 87f5a39 into callstack:master May 6, 2020
@jbtheard jbtheard deleted the fix/pod branch May 23, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants