fix: call the gradle wrapper correctly on windows #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
approved these changes
Jun 2, 2021
Member
BartoszKlonowski
left a comment
BartoszKlonowski
left a comment
There was a problem hiding this comment.
Thank you for this!
As a sidenote:
The best way to automatically link your pull request to the issue you fix is to use fixes or closes keywords when creating the PR.
Closed
Author
Aha, I couldn't remember what it was that did that. Thank you! |
Author
|
Hi, is there anything left that needs doing to get this merged? |
okwasniewski
pushed a commit
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses this issue by fixing the command used to call the gradle wrapper on Windows.
Test plan
Following the steps outlined in the issue linked above should no longer result in an error that says the gradle wrapper doesn't appear to be present.