Add socket_peerpidfd
#1474
Add socket_peerpidfd
#1474
Conversation
|
|
| #[test] | ||
| #[serial] // for `setrlimit` usage, and `crate::init` | ||
| fn test_select_with_maxfd_sockets() { | ||
| use rustix::fd::{FromRawFd as _, OwnedFd}; |
There was a problem hiding this comment.
I'm curious why these lines were needed in the tests, that weren't otherwise changed.
There was a problem hiding this comment.
That fixes a compile error with cargo test --features net,process,event. Though it also works to use --features=all-apis like CI uses. (I suppose ideally it shouldn't error for any combination of features; but doesn't matter that much for tests.)
|
Those imports are unfortunately evoking warnings, which are currently configured to be errors in CI. Could you add conditionals to the imports so that they're not imported if they're not needed? |
ids1024
force-pushed
the
socket_peerpidfd
branch
from
ab3c1ac to
896e94b
Compare
|
Huh, looking at CI, I guess Not sure why those are defined separately for Android; I'd assume unless the C standard library is doing something weird, those particular definitions should be the same for anything with a Linux kernel. |
```
error[E0283]: type annotations needed
--> tests/net/addr.rs:34:20
|
34 | cstr!("/").into()
| ^^^^ cannot infer type for type parameter `U`
|
= note: cannot satisfy `_: From<&CStr>`
= note: required for `&CStr` to implement `Into<_>`
```
```
error[E0283]: type annotations needed
--> tests/path/arg.rs:19:32
|
19 | assert_eq!(cstr!("hello"), Borrow::borrow(&t.as_cow_c_str().unwrap()));
| ^^^^^^^^^^^^^^ -------------------------- type must be known at this point
| |
| cannot infer type of the type parameter `Borrowed` declared on the trait `Borrow`
|
= note: multiple `impl`s satisfying `Cow<'_, CStr>: Borrow<_>` found in the following crates: `alloc`, `core`:
- impl<'a, B> Borrow<B> for Cow<'a, B>
where B: ToOwned, B: ?Sized;
- impl<T> Borrow<T> for T
where T: ?Sized;
help: consider specifying the generic argument
|
19 | assert_eq!(cstr!("hello"), Borrow::<Borrowed>::borrow(&t.as_cow_c_str().unwrap()));
| ++++++++++++
```
|
@ids1024 Thanks so much for doing this. Do you intend to finish this PR? |
ids1024
force-pushed
the
socket_peerpidfd
branch
3 times, most recently
from
e7427e1 to
34551eb
Compare
|
I guess to pass CI this could just be disabled on Android. Presumably Tests seem to be broken with a recent compile, so I rebased this on #1523. Looks like there are a couple other unrelated CI errors? But I think this should be mergeable. |
ids1024
force-pushed
the
socket_peerpidfd
branch
from
3cf9ce1 to
e8980ab
Compare
Supported on Linux since 6.5.
ids1024
force-pushed
the
socket_peerpidfd
branch
from
e8980ab to
9f77ef6
Compare
|
Or well, one of the errors was related to this change. Fixed that, and added a commit for another CI error. So now everything is passing. |
4 participants
Supported on Linux since 6.5.
I see
socket_peercredis only provided on Linux, while OpenBSD (https://man.openbsd.org/getsockopt.2) has some version ofSO_PEERCRED, and FreeBSD (https://man.freebsd.org/cgi/man.cgi?unix(4)) has aLOCAL_PEERCRED(libwayland for instance has code to use those on their respective platforms). These APIs do seem to be slightly different though. In any case,SO_PEERPIDFDis definitely Linux-specific for the time being.