Skip to content

Conversation

toote
Copy link
Contributor

@toote toote commented Jan 10, 2024

Reduced the complexity of the cache-from option. Now it is just a pass-through to the corresponding options in docker compose. This means that:

  • images will not be pulled by the plugin (docker should take care of that)
  • there are no more groups
  • the option format simplification makes it possible to support all formats available in the underlying docker engine

@toote toote requested review from pzeballos and tomowatt January 10, 2024 09:15
@toote toote requested a review from tomowatt January 17, 2024 05:09
Copy link
Contributor

@tomowatt tomowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, and testing the changes worked in all the scenarios I devised

@tomowatt
Copy link
Contributor

@toote are you able to assist with the conflicts here?
I've tried fixing them up locally e.g.,

git checkout toote_build_simplification  
git checkout toote_cache_from 
git merge toote_build_simplification  

But running the tests locally ends up with a lot of failures

The merges of the previous PRs worked fine with the tests but hesistant to push anything in case of messing more up

@toote
Copy link
Contributor Author

toote commented Feb 15, 2024

@toote are you able to assist with the conflicts here? I've tried fixing them up locally e.g.,

But running the tests locally ends up with a lot of failures

The merges of the previous PRs worked fine with the tests but hesistant to push anything in case of messing more up

Apparently, I forgot to do a mergeback in the pile of PRs I created which caused these conflicts. So sorrry :(

I have resolved them all and confirmed that there shouldn't be any more in the remaining PRs.

While I was at it, I had to review a lot of tests so I did some refactoring to remove around 500+ unnecessary lines :)

Base automatically changed from toote_build_simplification to master February 16, 2024 09:41
@tomowatt tomowatt merged commit 92c46d0 into master Feb 16, 2024
@tomowatt tomowatt deleted the toote_cache_from branch February 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to set cache-to to use registry cache?
3 participants