-
Notifications
You must be signed in to change notification settings - Fork 156
Cache from simplification #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me, and testing the changes worked in all the scenarios I devised
…dates Documentation updates
CLI v2 as default
@toote are you able to assist with the conflicts here?
But running the tests locally ends up with a lot of failures The merges of the previous PRs worked fine with the tests but hesistant to push anything in case of messing more up |
Apparently, I forgot to do a mergeback in the pile of PRs I created which caused these conflicts. So sorrry :( I have resolved them all and confirmed that there shouldn't be any more in the remaining PRs. While I was at it, I had to review a lot of tests so I did some refactoring to remove around 500+ unnecessary lines :) |
Reduced the complexity of the
cache-from
option. Now it is just a pass-through to the corresponding options in docker compose. This means that: