Skip to content
This repository was archived by the owner on May 29, 2025. It is now read-only.

Conversation

tdy
Copy link

@tdy tdy commented Feb 26, 2021

Following up on #151, this PR enables users to set the language via make rather than manually editing the script, e.g.,

$ make LANGUAGE="en_US" install

Edit: I just noticed the contrib guidelines about basing new features on develop. I don't know if that applies to a small patch like this. I can rebase on develop if preferred.

@Genghius
Copy link
Contributor

ehhhh....
this is....
yesn't...
like.....
bruh.

do people hate editing a single line that much?

@tdy
Copy link
Author

tdy commented Feb 27, 2021

do people hate editing a single line that much?

This is mainly to support packaging workflows, like arch's AUR.

@BeyondMagic
Copy link
Contributor

Edit: I just noticed the contrib guidelines about basing new features on develop. I don't know if that applies to a small patch like this. I can rebase on develop if preferred.

nah, it's preferably here. develop is not being developed anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants