Skip to content

Conversation

@pastacolsugo
Copy link
Contributor

This enhancement introduces the ability to select the current directory (.) when browsing directories in the CLI file selector, improving user experience and navigation efficiency.
Key Improvements:

Provides a straightforward method to select the default path when already in the target directory
Eliminates the previous workaround of navigating up a directory to select the current location
Enables immediate directory validation by allowing selection while viewing directory contents

The implementation adds the ./ option to the directory listing, giving users a more intuitive and direct way to choose their desired path.

@br14n-sol
Copy link
Owner

Ideally, this option should be shown only when the type value is set to 'directory' or 'file+directory'.

In the current implementation this option would be present at all times, becoming redundant when you only want to select a file and not a directory.

@pastacolsugo
Copy link
Contributor Author

pastacolsugo commented Nov 25, 2024

Hello @br14n-sol,

I agree, I addressed it in my latest commit.

@br14n-sol
Copy link
Owner

Everything seems to work as expected, any adjustments can be made later.

to finish simply squash the two commits into one, since the fix only happened here it is not necessary to send it in a separate commit.

remember to use the lowercase commit type, as shown in conventional commits

Added the ability to select the current directory by presenting the `./` option.
The `./` option is available only when selecting for `directory` or
`file+directory`.

Changes:
- Modified: src/index.ts
- Modified: src/utils.ts
@pastacolsugo
Copy link
Contributor Author

Updated as requested 🍝

@br14n-sol br14n-sol merged commit 719b811 into br14n-sol:main Nov 28, 2024
@br14n-sol
Copy link
Owner

br14n-sol commented Nov 28, 2024

Thank you for contributing 🫡

@pastacolsugo
Copy link
Contributor Author

Thank you for developing it!

Do you have an ETA for the next release? I'm interested in using it directly from npm

@br14n-sol
Copy link
Owner

Thank you for developing it!

Do you have an ETA for the next release? I'm interested in using it directly from npm

Probably during the course of this weekend.

@br14n-sol
Copy link
Owner

Released 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants