-
Couldn't load subscription status.
- Fork 228
Move Boost::crc and Boost::program_options dependencies from library to unit and robustness tests #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not an actual dependency.
|
Sorry, might have opened this without doing proper research. |
|
OK, reopened now that I've put the Boost::crc dependency where it needs to go (on the unit tests). |
|
The merge status is unknown and no amount of rechecking is fixing it, so I seem to be blocked from merging. PS. Which, btw, is a status and button that only seems to appear on the mobile app; at least, I can't find it on the desktop version. |
|
@barendgehrels are you able to merge this or does it require more approvals? I'm just getting an error from GitHub. |
I'll check. |
@jeremy-murphy it does not build for me, because some of the robustness tests don't go via It works if it is, instead, added in Side note: |
For convenience my diff (with branch But ignore the removal of |
|
|
Not an actual dependency of the library. Discovered when I tried to make Boost.Geometry a dependency of Boost.Graph, the CMake breaks.