Install extra/ directory, and configure .natvis files on Windows #89
Conversation
|
Let's leave BOOST_INSTALL_INCLUDE_SUBDIR alone and (always, regardless of layout) install into CMAKE_INSTALL_DATADIR/boost-1.90.0. I'll take a look at the rest later. |
|
It makes more sense to have matching installation for |
|
No, I don't think it does. The include subdir is maintained for consistency with I don't think that dumping all the So to avoid dumping random things into |
|
Understood, I can make that change, and remove the configurability from it. |
| if("${src}" STREQUAL "${extradir}/${natvis_file}" OR "${src}" STREQUAL "$<BUILD_INTERFACE:${extradir}/${natvis_file}>") | ||
|
|
||
| # Remove this .natvis file from the INTERFACE_SOURCES target property, | ||
| # only if it appears as a direct path, not a generator expression. |
There was a problem hiding this comment.
Why do we remove the .natvis file only when it's not a generator expression? We add it unconditionally below.
| # Extract the library name as the component of the path, one up from the extra directory | ||
| get_filename_component(libname "${__EXTRA_DIRECTORY}" DIRECTORY) | ||
| get_filename_component(libname "${libname}" NAME) | ||
| string(REGEX REPLACE "\\/boost\\-" "/boost_${libname}-" extra_subdir "${__boost_default_include_subdir}") |
There was a problem hiding this comment.
I don't understand this logic. What is it supposed to do?
Follow-up of #81