Skip to content

Declare dateFormatter as public and use shared dateFormatter instance in formattedStringForDate #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Declare dateFormatter as public and use shared dateFormatter instance in formattedStringForDate #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MHPrettyDate/MHPrettyDate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ typedef enum

@interface MHPrettyDate : NSObject

@property (nonatomic, strong) NSDateFormatter *dateFormatter;

+(NSString*) prettyDateFromDate:(NSDate*) date withFormat:(MHPrettyDateFormat) dateFormat;
+(NSString*) prettyDateFromDate:(NSDate*) date withFormat:(MHPrettyDateFormat) dateFormat withDateStyle:(NSDateFormatterStyle) dateStyle;
+(NSString*) prettyDateFromDate:(NSDate*) date withFormat:(MHPrettyDateFormat) dateFormat withDateStyle:(NSDateFormatterStyle) dateStyle withTimeStyle:(NSDateFormatterStyle) timeStyle;
Expand Down
3 changes: 1 addition & 2 deletions MHPrettyDate/MHPrettyDate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ @interface MHPrettyDate()
@property (readonly, nonatomic) NSDate* tomorrow;
@property (readonly, nonatomic) NSDate* weekAgo;
@property (readonly, nonatomic) NSCalendar* calendar;
@property (strong, nonatomic) NSDateFormatter* dateFormatter;
@property (assign) MHPrettyDateFormat dateFormat;

+(MHPrettyDate*) sharedInstance;
Expand Down Expand Up @@ -233,7 +232,7 @@ +(NSString*) formattedStringForDate:(NSDate*) date withFormat:(MHPrettyDateForma
+(NSString*) formattedStringForDate:(NSDate*) date withFormat:(MHPrettyDateFormat) dateFormat withDateStyle:(NSDateFormatterStyle) dateStyle withTimeStyle:(NSDateFormatterStyle) timeStyle
{
NSString* dateString;
NSDateFormatter* formatter = [[NSDateFormatter alloc] init];
NSDateFormatter* formatter = [[self sharedInstance] dateFormatter];

if ([MHPrettyDate willMakePretty:date])
{
Expand Down