Skip to content

Conversation

@klkvr
Copy link
Collaborator

@klkvr klkvr commented Jun 4, 2025

This field is very easy to forget about, and have caused weird bugs multiple times already. It can also always be easily inferred from the specified TxEnv values.

This PR removes the tx_env and adjusts logic to be invoked based on present fields instead

@klkvr klkvr changed the title refactor: remove TxEnv::tx_type field refactor!: remove TxEnv::tx_type field Jun 4, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 4, 2025

CodSpeed Performance Report

Merging #2580 will degrade performances by 3.37%

Comparing klkvr/rm-txtype (6062573) with main (a3d2006)

Summary

❌ 1 regressions
✅ 157 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
PUSH7_50 21.5 µs 22.3 µs -3.37%

@klkvr klkvr force-pushed the klkvr/rm-txtype branch from 8c05366 to 12aae0e Compare June 5, 2025 04:31
@klkvr
Copy link
Collaborator Author

klkvr commented Jun 5, 2025

It seems that there are some statetests failing that don't make much sense in scope of our usage patterns — e.g there are tests asserting that eip7702 tx with empty auth list will fail validation

however, the way TxEnv is handled with this PR is that transaction will not be considered to be 7702 tx unless it has a non-empty authorization list

should we just ignore those kinds of tests that don't fit into our tx representation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants