fix invisible text in language selector #4504
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On small-screen desktop viewports, the language selector renders with a white background and white text, making the options completely invisible. This effectively blocks users from being able to select or change their language in those conditions (unless hovering over each option to reveal the text with the blue highlighter). On mobile devices, the native browser UI handles the selector's styling automatically, so the issue only appears in non-mobile small screens.
This update fixes the issue by explicitly styling the language selector with a black background, in keeping with the style of the mobile menu, so that the text remains visible and accessible across all devices.
Before
After
