-
Notifications
You must be signed in to change notification settings - Fork 220
Embeddings with hoplite #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is awesome, great work Max! A few minor things to (maybe) change:
|
|
ok, it really seems that we can't search in databases with more than one dataset. The GUI only shows the sample count of the first database and search fails with an error similar to the one above (different indices). |
|
everything else seems to work like a charm :) |
|
One other thing I realized: When people set a band pass filter during embeddings extraction, is that being applied during search? |
…ll needs changes)
…s. exported audio is cut from the original
birdnet_analyzer/gui/embeddings.py
Outdated
| with gr.Row(): | ||
| if db_path != None and len(results) > 0: | ||
| db = search.getDatabase(db_path) | ||
| settings_path = os.path.join(db_path, "birdnet_analyzer_settings.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we move that into gui-settings.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, the settings are per database and need to be saved along them. i will change this to use the metadata from the hoplite db, so no separate file is created.
No description provided.