[8.4.0] Introduce shorten_virtual_includes cc toolchain feature #26532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bzl to cc_helper_internal.bzl PiperOrigin-RevId: 759147398 Change-Id: I5f1f3e4ee9f76a2de8768f49163e3103993d3c0b
Fixes bazelbuild#18683 Related: protocolbuffers/protobuf#20085 This change is a rework of bazelbuild#26005 to enable short virtual includes based on a cc feature, therefore we can limit the change to only MSVC compiler on Windows. RELNOTES: If a cc toolchain feature named `shorten_virtual_includes` is enabled, virtual include header files are linked under `bin/_virtual_includes/<hash of target path>` instead of `bin/<target package path>/_virtual_includes/<target name>`. This shortens the virtual include paths which is critical for mitigating long path issue with MSVC on Windows. Closes bazelbuild#26528. PiperOrigin-RevId: 781975309 Change-Id: Ia573a5f25707ad2462aa3a4459fc66db1779df36
github-actions
bot
added
team-Configurability
PiperOrigin-RevId: 782002621 Change-Id: I8634c95c51e2325d12fa4e200708f1701c66193d
Wyverald
approved these changes
Jul 11, 2025
Merged
via the queue into
bazelbuild:release-8.4.0
with commit Jul 11, 2025
26216ac
46 checks passed
github-actions
bot
removed
the
awaiting-review
mtrackeros
approved these changes
Aug 7, 2025
mtrackeros
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18683
Related: protocolbuffers/protobuf#20085
This change is a rework of #26005 to enable short virtual includes based on a cc feature, therefore we can limit the change to only MSVC compiler on Windows.
RELNOTES: If a cc toolchain feature named
shorten_virtual_includesis enabled, virtual include header files are linked underbin/_virtual_includes/<hash of target path>instead ofbin/<target package path>/_virtual_includes/<target name>. This shortens the virtual include paths which is critical for mitigating long path issue with MSVC on Windows.Closes #26528.
PiperOrigin-RevId: 781975309
Change-Id: Ia573a5f25707ad2462aa3a4459fc66db1779df36