use DefaultInfo in Bazel's embedded Starlark #26276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Starlark embedded in Bazel, that can get used when building
other repos, has problems exposed by enabling
--incompatible_disable_target_default_provider_fields
Since this code is embedded in Bazel, there is no way for users to
patch it in the course of trying to disable target default provider
fields in their own repos. We here address these issues.
github-actions
bot
added
the
awaiting-review
|
@bazel-io fork 8.3.0 |
|
@pzembrod Perhaps you could review this? |
|
@bazel-io fork 8.3.0 |
|
@meteorcloudy Perhaps you could review this? Or perhaps identify an appropriate reviewer? |
pzembrod
added
awaiting-PR-merge
iancha1992
added
the
team-Starlark-Interpreter
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jun 13, 2025
The Starlark embedded in Bazel, that can get used when building other repos, has problems exposed by enabling
--incompatible_disable_target_default_provider_fields
Since this code is embedded in Bazel, there is no way for users to patch it in the course of trying to disable target default provider fields in their own repos. We here address these issues.
Closes bazelbuild#26276.
PiperOrigin-RevId: 770991995
Change-Id: I4b29e9d52dd1789afe7de990ca9500812a8ec211
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
The Starlark embedded in Bazel, that can get used when building other
repos, has problems exposed by enabling
--incompatible_disable_target_default_provider_fields
Since this code is embedded in Bazel, there is no way for users to patch
it in the course of trying to disable target default provider fields in
their own repos. We here address these issues.
Closes #26276.
PiperOrigin-RevId: 770991995
Change-Id: I4b29e9d52dd1789afe7de990ca9500812a8ec211
Commit
7846859
Co-authored-by: David Sanderson <[email protected]>
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…der_fields We here address obstacles to building Bazel with `--incompatible_disable_target_default_provider_fields` enabled. This includes patches representing - bazelbuild/apple_support#413 - bazelbuild/rules_java#303 - grpc/grpc-java#12148 which should be removed once these PRs have been included in releases of their respective repos. All of these pull requests have been approved and merged into their respective repositories. Once #26276 is cherry-picked into a Bazel 8 release, we should be able to update `.bazelversion` to that release, and in conjunction with the changes herein, we should be able to enable `--incompatible_disable_target_default_provider_fields` in `.bazelrc` in order to prevent regressions. Ideally, we could also flip the default value of this flag once #26297 also lands. Note that #26293 is related, but not strictly needed for builds. Closes #26272. PiperOrigin-RevId: 772542631 Change-Id: Ib5db3ffa3f4857199a6f8d838078d7ced2281ba3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Starlark embedded in Bazel, that can get used when building other repos, has problems exposed by enabling
Since this code is embedded in Bazel, there is no way for users to patch it in the course of trying to disable target default provider fields in their own repos. We here address these issues.