-
-
Notifications
You must be signed in to change notification settings - Fork 250
support runtime/test-time compiler invokations #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I based this pr off v1.4.0 because for some reason using the master does not build on my project |
437774d
to
37b0fef
Compare
Do you have any idea why tests fail in ci? They seem to pass locally when running |
One failing test is |
Should be good I think |
@TroyKomodo Could you rebase onto master and ping me for the final approval? |
Head branch was pushed to by a user without write access
453869e
to
9b288a8
Compare
@fmeum I have rebased, the one issue with master vs 1.4.0 is it seems my project fails to build on master. |
Can you bisect this down to a breaking commit? Feel free to share the error, maybe I know what's up. Thanks for the PR in any case! |
|
Cc @helly25 |
This commit changes the cc_wrapper.sh script to allow for it to find paths when invoked at runtime with runfiles as apposed to strictly using build-rule invokes.
fixes #517
Work towards buildbuddy-io/bazel_env.bzl#51