Skip to content

Conversation

dennisameling
Copy link
Contributor

PR Checklist

Let me know if this needs any tests or docs. GitHub Actions has native Windows arm64 runners that we could use for tests if desired.

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently, only windows_amd64 is supported, but not windows_arm64.

Issue Number: N/A

What is the new behavior?

This PR introduces support for windows_arm64, which has been supported as of NodeJS v20.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

aspect-workflows bot commented Jul 13, 2025

Test

All tests were cache hits

2 tests (100.0%) were fully cached saving 73ms.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexeagle alexeagle merged commit 12d90ec into bazel-contrib:main Jul 14, 2025
17 checks passed
@dennisameling
Copy link
Contributor Author

@alexeagle thanks for the approval and merge. Any chance a new version of rules_nodejs could be released? This is currently blocking aspect-build/rules_js#2276. Thanks! 😊

@jbedard
Copy link
Collaborator

jbedard commented Aug 1, 2025

I've tagged 6.5.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants