[JENKINS-57886] Modernize and add JCasC

[jetersen]

You really ought to target higher Jenkins Core on newer projects.
I prepared the plugin for incremental and cleaned up pom, added sensible checkstyle.

I have added test dependency to JCasC, you can now use hpi:run to see JCasC in action http://localhost:8080/jenkins/configuration-as-code

I can see JCasC catches GitLab servers just fine.

[baymac]

@Casz Try to rebase this branch with develop periodically so that we avoid merge conflicts.

[jetersen]

Already rebased once 😓 no worries 🤣

[jetersen]

CI is currently running here: https://travis-ci.com/casz/gitlab-branch-source-plugin-1

Once merged and you enable travis-ci for the repo we should be golden 😅

[baymac]

I am unable to compile it, how can I test it then? 🤔

[jetersen]

Comment out the broken test GitLabAuthSourceTest

[baymac]

I am getting this scary error: https://gist.github.com/baymac/8e36ffdfc9a7bd30a18f546f756dee15

[jetersen]

@baymac mvn clean verify you ought to clean your target folder once in a while, especially when I go around updating plugin pom and Jenkins core.

[baymac]

mvn clean verify gives the same error. Something like:

[ERROR] error reading /home/parichay/.m2/repository/org/jenkins-ci/main/jenkins-core/2.138.4/jenkins-core-2.138.4.jar; zip file is empty
...

[jetersen]

You can always clean your local maven repo when it goes foobar 😓
rm -rf /home/parichay/.m2/repository/org/jenkins-ci/main/*

[baymac]

Did that. Now getting a different less scary error: https://gist.github.com/baymac/934417304e1f03ae09e363be1ffb6171

[jetersen]

SpotBugs is properly correct on that matter, it wants the field to be static which makes total sense the object should only be instantiated once. No need to have an instance of GitLab Token length for each 😓

[markjacksonfishing]

lgtm

[baymac]

Still getting this error:

[INFO] Inconsistent synchronization of io.jenkins.plugins.gitlabserver.servers.GitLabServers.servers; 
locked 80% of time [io.jenkins.plugins.gitlabserver.servers.GitLabServers, io.jenkins.plugins.gitlabserver.servers.GitLabServers, 
io.jenkins.plugins.gitlabserver.servers.GitLabServers, 
io.jenkins.plugins.gitlabserver.servers.GitLabServers, 
io.jenkins.plugins.gitlabserver.servers.GitLabServers] Unsynchronized access at GitLabServers.java:[line
 54]Synchronized access at GitLabServers.java:[line 117]Synchronized access at GitLabServers.java:
[line 90]Synchronized access at GitLabServers.java:[line 90]Synchronized access at GitLabServers.java:
[line 91] IS2_INCONSISTENT_SYNC
[INFO] 

[jetersen]

@baymac should be fixed by the last force-push 😓

[jetersen]

https://travis-ci.com/casz/gitlab-branch-source-plugin-1/builds/114671128 green build

[justinharringa]

@Casz I'm assuming the token here is either fake or doesn't really have much access, right?

gitlab-branch-source-plugin/src/test/resources/io/jenkins/plugins/gitlabserver/casc/configuration-as-code.yml

Line 8 in c828def

token: "sAf_Xasnou47yxoAsC"

[jetersen]

@justinharringa I just took the one that was already included in the other test class 😓 I can generate one and throw it away 🐇

[justinharringa]

Just basically making sure if someone finds that token that they can't do anything that'll be nasty or net them a bunch of cryptocurrency. 😆

[markjacksonfishing]

lgtm

[baymac]

When you find time answer my queries. :)