Skip to content

Fix buffers #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix buffers #222

wants to merge 1 commit into from

Conversation

@particlebanana
Copy link
Contributor

@particlebanana particlebanana commented Jan 25, 2016

Removes the cloneDeep as described in #194.

All test pass but someone who is having this issue should test it to be sure.

@particlebanana
Copy link
Contributor Author

particlebanana commented Jan 26, 2016

Also it looks like a timing issue with the autoIncrement tests on travisci

@particlebanana
Copy link
Contributor Author

particlebanana commented Jan 27, 2016

Ok so the way buffers work needs to be setup from the top down, there is more than just removing a cloneDeep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@particlebanana