Drop eslint-config-prettier dependency #11432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jNullj
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
We still use the config, as it's loaded from the plugin.
It's both added as a dependency and also mentioned on this section of the readme that eslint-plugin-prettier loads eslint-config-prettier.
But as you mentioned, we don't call this directly, a more proper way may be letting npm install eslint-config-prettier without explicitly making it one of our dev dependencies.
|
Indeed! But yeah, what I meant is that we should not need to worry, what config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the dependency audit started in #11425.
According to its README, eslint-config-prettier:
Sure, that sounds potentially useful on paper. But we're no actually using that plugin directly, it isn't added to our ESLint configuration file. We're leveraging
eslint-plugin-prettier/recommended, that brings in a sane config.