Remove node-env-flag dependency #11429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jNullj
changed the title
jNullj
requested changes
Oct 18, 2025
| } | ||
|
|
||
| const skipIntercepted = envFlag(process.env.SKIP_INTERCEPTED, false) | ||
| const skipIntercepted = process.env.SKIP_INTERCEPTED === 'true' |
There was a problem hiding this comment.
We don't have to give up functionality.
Suggested change
| const skipIntercepted = process.env.SKIP_INTERCEPTED === 'true' | |
| const skipIntercepted = process.env.SKIP_INTERCEPTED.trim().toLowerCase() === 'true' |
There was a problem hiding this comment.
That won't work, as process.env.SKIP_INTERCEPTED can be undefined; we'd also not be covering the SKIP_INTERCEPTED=1 case, which was technically previously supported.
Given probably no one has used this option in years, I really think we should go with the simplest implementation possible, i.e. the equality check. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the dependency audit started in #11425.
SKIP_INTERCEPTEDis in all likelihood rarely if ever leveraged when running the tests. Rather that depending on an external dependency to support different input formats (SKIP_INTERCEPTED=TRUE,SKIP_INTERCEPTED=true,SKIP_INTERCEPTED=1), let's just force contributors to use the lowercase version whenever one of them next feels the need to use this flag.