fix: update typedef to support async version #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? This PR updates the
AxMultiMetricFn
type definition so that it can support asynchronous codeWhat is the current behavior?
AxMultiMetricFn
only accept non-async function due to its return typeRecord<string, number>
What is the new behavior (if this is a feature change)? Added
Promise<Record<string, number>>
as one of the return type so user can use the metricFn as asynchronous (LLM-judge, etc...)Other information:
src/ax/dsp/optimizer.ts
correctly haveawait
before