Update PR template for an improved reviewing experience #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing and why?
In this section, a developer would briefly but clearly explain the changes they made. Here is an example of this:
This is a demo of an updated PR template that our team can adopt. As you will notice, this new template encourages the requester to focus on 5 key things:
Before/After UX
In this section, a developer would elaborate on the before/after user experience to clarify to reviewers the benefit of their changes. Here is an example of this:
Before:
The previous team template was not being thoroughly used and did not require thorough explanations of the changes that were made along with how those changes were tested. This would often lead to confusion for the reviewer and basic mistakes for the requester (e.g. forgetting to include unit tests).
After:
The hope is that this current template will provide developers a structured way of telling their reviewers clearly and effectively what changes they made and also how it is currently being tested. This should simplify communication between developer and reviewer and hopefully allow for faster reviews.
How was this change tested?
In this section, a developer would describe how their changes were tested. Here is an example of this:
(SAMPLE RESPONSE): Unit tests were provided for typical usage and various edge-cases that a user might encounter. This includes a happy-case workflow along with handling of incorrect usage and parameters set to their extreme values. In total, these tests provide 100% code coverage of the new changes made. The team plans to incorporate integration testing for these changes, but these tests are still under development.
The following three sections provide a checklist for the requester to communicate additional information as needed:
Unit test coverage
Do we need integration tests?
Checklist