Skip to content

Conversation

jam-jee
Copy link
Collaborator

@jam-jee jam-jee commented Aug 19, 2025

Asana task : https://app.asana.com/1/8442528107068/project/1210871127267532/task/1211094231574094?focus=true
Requirement :

Can we support a simple command hyp --version  to know which CLI version is installed (and potentially list also the versions of the CRD templates.

Testing :

  • Local test
> hyp --version
hyp version: 3.1.0
hyperpod-pytorch-job-template version: 1.1.0
hyperpod-custom-inference-template version: 1.0
hyperpod-jumpstart-inference-template version: 1.0

PR Approval Steps

For Requester

  1. Description
    • Check the PR title and description for clarity. It should describe the changes made and the reason behind them.
    • Ensure that the PR follows the contribution guidelines, if applicable.
  2. Security requirements
  3. Manual review
    1. Click on the Files changed tab to see the code changes. Review the changes thoroughly:
      • Code Quality: Check for coding standards, naming conventions, and readability.
      • Functionality: Ensure that the changes meet the requirements and that all necessary code paths are tested.
      • Security: Check for any security issues or vulnerabilities.
      • Documentation: Confirm that any necessary documentation (code comments, README updates, etc.) has been updated.
  4. Check for Merge Conflicts:
    • Verify if there are any merge conflicts with the base branch. GitHub will usually highlight this. If there are conflicts, you should resolve them.

For Reviewer

  1. Go through For Requester section to double check each item.
  2. Request Changes or Approve the PR:
    1. If the PR is ready to be merged, click Review changes and select Approve.
    2. If changes are required, select Request changes and provide feedback. Be constructive and clear in your feedback.
  3. Merging the PR
    1. Check the Merge Method:
      1. Decide on the appropriate merge method based on your repository's guidelines (e.g., Squash and merge, Rebase and merge, or Merge).
    2. Merge the PR:
      1. Click the Merge pull request button.
      2. Confirm the merge by clicking Confirm merge.

@jam-jee jam-jee requested a review from a team as a code owner August 19, 2025 18:34
@jam-jee
Copy link
Collaborator Author

jam-jee commented Aug 19, 2025

Skipped adding unit tests, as versions used by different software versions would be different.

try:
from importlib.metadata import version, PackageNotFoundError
except ImportError:
from importlib_metadata import version, PackageNotFoundError
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we importing it again if there is ImportError?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.. let me clean this up..

@jam-jee jam-jee merged commit 9c07154 into aws:main Aug 19, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants