Skip to content

Conversation

@dougch
Copy link
Contributor

@dougch dougch commented Oct 14, 2025

Release Summary:

Resolved issues:

none

Description of changes:

Based on minor changes to #5327

Example release run:

./generate_release_notes.py  --release-commit 6aefe741f17489211f6c28e837c1a65ee66a1ef2
cat release_notes.md

Weekly release for Oct 27, 2025

Release Summary:

  • Multiple changes to the s2n-tls default policy:
  1. Added TLS13 support
  2. Added Post-Quantum key exchange
  3. Removed CBC ciphersuites
  • Adds support for PQ only policies, which should not include classical ECC curves. This feature only works on libcryptos that support TLS 1.3 and PQ kem groups.
    • Removes RSA key exchange and DHE cipher suites from the rfc9151 named security policy. Use the numbered version of this policy instead (20250429) to maintain the current preferences.
  • Fixed a validation issue in s2n_connection_deserialize() where malformed protocol version bytes could result in invalid connection state and inconsistent TLS behavior.
  • Add a synchronous rust binding API for s2n_cert_validation_callback
  • Upgrades MSRV for extended crates (s2n-tls-sys, s2n-tls, s2n-tls-tokio) from 1.63 to 1.72

What's Changed:

Full Changelog: https://github.com/aws/s2n-tls/compare/30f40f2345a89570ed3c4cee2274942f1ebf85fa..6aefe741f17489211f6c28e837c1a65ee66a1ef2


Call-outs:

This script could do much more to streamline the process, this is a starting point for more iteration.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Locally/CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Oct 14, 2025
@dougch dougch requested a review from boquan-fang October 14, 2025 23:32
@dougch dougch requested review from lrstewart and maddeleine and removed request for boquan-fang and lrstewart October 20, 2025 22:23
@dougch dougch requested a review from maddeleine October 28, 2025 18:25
@dougch dougch marked this pull request as ready for review October 28, 2025 20:14
fh.write("\n## Release Summary:\n")
for summary in release_summaries:
fh.write(f"- {summary}\n")
fh.write("\n\n## What's Changed:\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need changelog generation in this script? It was my understanding that this was already done automatically.
I'm trying to think about at which point in our release process would we run this generate release notes script. Like, we need the release notes before we work on the github script IIRC. But I don't think we also need the changelog part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would replace the automatically generated notes. I have a draft PR showing how we could add a config file to customize, slightly, the generated notes, but the way we're doing a release summary requires a script.

```
if you use the [GitHub CLI](https://cli.github.com/) utility, you could use: `GITHUB_TOKEN=$(gh auth token)`.

You can generate personal access tokens here: https://github.com/settings/personal-access-tokens, which should result in something that looks like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What permissions do we need to give our PAT? Based on my experimentation you do not need to add any.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, basic repo:status should be enough.

`uv` will automatically configure dependencies. To run `script.py` use `uv run script.py`.

### Release Script
To run the release note script you need to pass in a github token through an environment variable. This is because unauthenticated users are limited to 60 API calls per _hour_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

60 API calls per hour doesn't sound like a lot. How many API calls does this script need?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more to the story...unauthenticated users are tracked by their IP address, so if we're all going out the same IP Gateway/NAT... those 60 calls could be shared across an entire office/org/metro area.

@dougch dougch marked this pull request as draft October 31, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants