Semantic search tool integration #2154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liumofei-amazon
force-pushed
the
workspaceContext_tool
branch
from
527620f to
d368473
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/server-side-semantic-search #2154 +/- ##
======================================================================
Coverage ? 59.70%
======================================================================
Files ? 255
Lines ? 55820
Branches ? 3290
======================================================================
Hits ? 33325
Misses ? 22431
Partials ? 64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liumofei-amazon
force-pushed
the
workspaceContext_tool
branch
2 times, most recently
from
216b5f8 to
779934a
Compare
liumofei-amazon
force-pushed
the
workspaceContext_tool
branch
from
779934a to
10de36d
Compare
LiGaCu
reviewed
Aug 25, 2025
...s-lsp-codewhisperer/src/language-server/agenticChat/tools/workspaceContext/semanticSearch.ts
Outdated
Show resolved
Hide resolved
LiGaCu
reviewed
Aug 25, 2025
server/aws-lsp-codewhisperer/src/language-server/workspaceContext/workspaceFolderManager.ts
Outdated
Show resolved
Hide resolved
LiGaCu
reviewed
Aug 25, 2025
server/aws-lsp-codewhisperer/src/language-server/workspaceContext/workspaceContextServer.ts
Outdated
Show resolved
Hide resolved
liumofei-amazon
force-pushed
the
workspaceContext_tool
branch
3 times, most recently
from
ff060e9 to
48d7608
Compare
jguoamz
requested changes
Aug 26, 2025
...s-lsp-codewhisperer/src/language-server/agenticChat/tools/workspaceContext/semanticSearch.ts
Outdated
Show resolved
Hide resolved
...s-lsp-codewhisperer/src/language-server/agenticChat/tools/workspaceContext/semanticSearch.ts
Show resolved
Hide resolved
...s-lsp-codewhisperer/src/language-server/agenticChat/tools/workspaceContext/semanticSearch.ts
Outdated
Show resolved
Hide resolved
...s-lsp-codewhisperer/src/language-server/agenticChat/tools/workspaceContext/semanticSearch.ts
Outdated
Show resolved
Hide resolved
...s-lsp-codewhisperer/src/language-server/agenticChat/tools/workspaceContext/semanticSearch.ts
Show resolved
Hide resolved
| @@ -1801,6 +1802,33 @@ export class AgenticChatController implements ChatHandlers { | |||
| case DisplayFindings.toolName: | |||
| // no need to write tool message for CodeReview or DisplayFindings | |||
| break | |||
| case SemanticSearch.toolName: | |||
There was a problem hiding this comment.
do we have UI mocks for this?
There was a problem hiding this comment.
No I don't think we have one, we were just based on existing tool style and trying to get it out for A/B. If there's any UI requirement needs to be polished we we can iterate it.
There was a problem hiding this comment.
can we get PM approval on the UX (if it's a native tool, we should have dedicated UI/UX for it)
server/aws-lsp-codewhisperer/src/language-server/agenticChat/agenticChatController.ts
Show resolved
Hide resolved
liumofei-amazon
changed the base branch from
main
to
feature/server-side-semantic-search
liumofei-amazon
force-pushed
the
workspaceContext_tool
branch
from
48d7608 to
e96f6d3
Compare
jguoamz
reviewed
Aug 27, 2025
...s-lsp-codewhisperer/src/language-server/agenticChat/tools/workspaceContext/semanticSearch.ts
Outdated
Show resolved
Hide resolved
liumofei-amazon
force-pushed
the
workspaceContext_tool
branch
from
e96f6d3 to
4d436cc
Compare
liumofei-amazon
force-pushed
the
workspaceContext_tool
branch
from
4d436cc to
33c28a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.