feat: send pinned context button immediately with pending state #2060
+89
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2025
manodnyab
reviewed
Aug 6, 2025
server/aws-lsp-codewhisperer/src/language-server/agenticChat/context/contextCommandsProvider.ts
Outdated
Show resolved
Hide resolved
constewart9
commented
Aug 7, 2025
| @@ -152,10 +168,12 @@ export class ContextCommandsProvider implements Disposable { | |||
| icon: 'image', | |||
| placeholder: 'Select an image file', | |||
| } | |||
| const workspaceCmd = { | |||
|
|
|||
| const workspaceCmd: ContextCommand = { | |||
There was a problem hiding this comment.
I am not sure why workspaceCmd was not a ContextCommand before. I think it was handled fine by duck typing but this change would bring better type safety. Can revert back if not necessary for this project
manodnyab
reviewed
Aug 18, 2025
| @@ -24,12 +28,27 @@ export class ContextCommandsProvider implements Disposable { | |||
| ) | |||
| } | |||
|
|
|||
| onReady() { | |||
| if (!this.initialStateSent) { | |||
| this.initialStateSent = true | |||
There was a problem hiding this comment.
can we add a comment on why this flag is required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In large workspaces, indexing can take a long time with no indication of status. Also, the "Pin Context" button does not appear until after indexing is complete.
Solution
The "Pin Context" is triggered immediately on startup by sending a file, folder, code, and workspace placeholder set to pending (aws/mynah-ui#421). Then, files/folders, code, and workspace are updated to active once their respective indexing processes are complete.
Should be merged after (first) aws/language-server-runtimes#652 and aws/mynah-ui#421
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.