Skip to content

Conversation

ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Jul 31, 2025

Problem

Webworker tests are no longer running in CI after integrating with codecov

Solution

Run tests as a separate ci step

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.11%. Comparing base (a8725b4) to head (720967a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2022   +/-   ##
=======================================
  Coverage   61.11%   61.11%           
=======================================
  Files         245      245           
  Lines       53301    53301           
  Branches     3224     3224           
=======================================
  Hits        32573    32573           
  Misses      20666    20666           
  Partials       62       62           
Flag Coverage Δ
unittests 61.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ctlai95 ctlai95 marked this pull request as ready for review August 5, 2025 00:07
@ctlai95 ctlai95 requested a review from a team as a code owner August 5, 2025 00:07
@francescoopiccoli
Copy link
Contributor

francescoopiccoli commented Aug 5, 2025

Did the webworker tests pass locally? the webworker breaking changes introduced in #1916 are still there. I have not tested locally myself but I would assume webworker tests still fail, and if we merge this PR, github actions will fail in all PRs and on main as soon as it merged. We should first fix the breaking changes (i.e. for instance substitute the fast-glob dependency with a browser-compatible dependency), and then reintroduce the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants