test(aws-client-retry-test): use Lambda client for retry test #7272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilkuri
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Noticed while attempting to upgrading vitest to 3.x because of a more strict error equality https://vitest.dev/guide/migration.html#more-strict-error-equality
The existing test seems to be incorrect as:
x-amzn-errortypeis specific to clients using JSON protocols, like Lambda, and ones using XML protocol, like S3ThrottlingException:aws-sdk-js-v3/private/aws-client-retry-test/src/ClientRetryTest.spec.ts
Line 100 in b585daa
ThrottledException: https://github.com/aws/aws-sdk-js-v3/blob/b585daac7f44db07fd51ddb8387555fb6366c6f6/private/aws-client-retry-test/src/ClientRetryTest.spec.ts#L35C39-L35C57Description
Uses Lambda Client (JSON protocol based) in retry test error checking
Testing
CI (verified working in vitest 3.x too)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.