test(clients): run endpoint tests in client mode #7130
Conversation
kuhe
changed the title
| throw new Error("ValidationError: prefixed hostname must be hostname compatible."); | ||
| } | ||
| } | ||
| b.hn(resolvedHostname); |
There was a problem hiding this comment.
- validate intended behavior
There was a problem hiding this comment.
Done, hostPrefix "RequestRoute" MUST be preserved. The test cases were unable to express this requirement.
I've hard coded an exception.
kuhe
force-pushed
the
test/endpoints
branch
5 times, most recently
from
3c7a602 to
4e0933e
Compare
kuhe
force-pushed
the
test/endpoints
branch
2 times, most recently
from
9c5bbc3 to
c28ca3a
Compare
| @@ -58,6 +59,19 @@ public List<String> runAfter() { | |||
| ); | |||
| } | |||
|
|
|||
| @Override | |||
| public void addConfigInterfaceFields(TypeScriptSettings settings, Model model, SymbolProvider symbolProvider, TypeScriptWriter writer) { | |||
There was a problem hiding this comment.
The PR adds the NodeConfigLoader to support the useArnRegion configuration property of S3Control.
Currently, only S3 has config loader support for this parameter, but the parameter is in both service models.
kuhe
force-pushed
the
test/endpoints
branch
2 times, most recently
from
d9a57b9 to
0909d3a
Compare
kuhe
changed the title
| clientStack.add(parseOutpostArnablesMiddleaware(options), parseOutpostArnablesMiddleawareOptions); | ||
| clientStack.add(updateArnablesRequestMiddleware(options), updateArnablesRequestMiddlewareOptions); | ||
| clientStack.addRelativeTo(parseOutpostArnablesMiddleaware(options), parseOutpostArnablesMiddleawareOptions); | ||
| clientStack.addRelativeTo(updateArnablesRequestMiddleware(options), updateArnablesRequestMiddlewareOptions); |
There was a problem hiding this comment.
parseOutpostArnablesMiddleaware (I didn't want to fix the typo for backwards compatibility reasons) is now before serializer and updateArnablesRequestMiddleware is after serializer.
This prevents them from interfering with endpoint resolution by rewriting the inputs too early, but still lets them do their jobs.
kuhe
force-pushed
the
test/endpoints
branch
3 times, most recently
from
9a8063b to
cdb7872
Compare
| @@ -129,7 +129,7 @@ describe("S3Control Client", () => { | |||
| expect(request.headers[HEADER_OUTPOST_ID]).eql(OutpostId); | |||
| expect(request.headers[HEADER_ACCOUNT_ID]).eql(AccountId); | |||
| expect(request.headers["authorization"]).contains( | |||
| `Credential=${credentials.accessKeyId}/${dateStr}/${region}/s3/aws4_request` | |||
| `Credential=${credentials.accessKeyId}/${dateStr}/${region}/s3-outposts/aws4_request` | |||
There was a problem hiding this comment.
this undoes the change from #4065
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
The client endpoint tests are now run through the client, including its full serializer behavior.
This also defers some legacy endpoint validations in S3 Control middleware to the endpoint rulesets.