Skip to content

Add default methods to AwsServiceClientConfiguration.Builder and SdkServiceClientConfiguration.Builder #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add default methods to AwsServiceClientConfiguration.Builder and SdkServiceClientConfiguration.Builder #4263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .../aws-core/src/main/java/software/amazon/awssdk/awscore/AwsServiceClientConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,21 +69,31 @@ public interface Builder extends SdkServiceClientConfiguration.Builder {
/**
* Return the region
*/
Region region();
default Region region() {
throw new UnsupportedOperationException();
}

/**
* Configure the region
*/
Builder region(Region region);
default Builder region(Region region) {
throw new UnsupportedOperationException();
}

@Override
Builder overrideConfiguration(ClientOverrideConfiguration clientOverrideConfiguration);
default Builder overrideConfiguration(ClientOverrideConfiguration clientOverrideConfiguration) {
throw new UnsupportedOperationException();
}

@Override
Builder endpointOverride(URI endpointOverride);
default Builder endpointOverride(URI endpointOverride) {
throw new UnsupportedOperationException();
}

@Override
Builder endpointProvider(EndpointProvider endpointProvider);
default Builder endpointProvider(EndpointProvider endpointProvider) {
throw new UnsupportedOperationException();
}

@Override
AwsServiceClientConfiguration build();
Expand Down
24 changes: 18 additions & 6 deletions core/sdk-core/src/main/java/software/amazon/awssdk/core/SdkServiceClientConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,27 +97,39 @@ public interface Builder {
/**
* Return the client override configuration
*/
ClientOverrideConfiguration overrideConfiguration();
default ClientOverrideConfiguration overrideConfiguration() {
throw new UnsupportedOperationException();
}

/**
* Return the endpoint override
*/
URI endpointOverride();
default URI endpointOverride() {
throw new UnsupportedOperationException();
}

EndpointProvider endpointProvider();
default EndpointProvider endpointProvider() {
throw new UnsupportedOperationException();
}

/**
* Configure the client override configuration
*/
Builder overrideConfiguration(ClientOverrideConfiguration clientOverrideConfiguration);
default Builder overrideConfiguration(ClientOverrideConfiguration clientOverrideConfiguration) {
throw new UnsupportedOperationException();
}

/**
* Configure the endpoint override
*/
Builder endpointOverride(URI endpointOverride);
default Builder endpointOverride(URI endpointOverride) {
throw new UnsupportedOperationException();
}


Builder endpointProvider(EndpointProvider endpointProvider);
default Builder endpointProvider(EndpointProvider endpointProvider) {
throw new UnsupportedOperationException();
}

/**
* Build the service client configuration using the configuration on this builder
Expand Down