This repository was archived by the owner on Jul 31, 2025. It is now read-only.
private/protocol/rest: Trim space in header key and value #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
fixup/RESTLeadingSpaceHeaders
branch
from
cabd873 to
d9dd43f
Compare
Merged
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Apr 9, 2019
Updates the REST protocol marshaler to trip leading and trailing space from header keys and values before setting the HTTP request header. Fixes a bug when using S3 metadata where metadata values with leading spaces would trigger request signature validation errors when the request is received by the service. V2 SDK port of: aws/aws-sdk-go#2460
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Apr 10, 2019
Updates the REST protocol marshaler to trip leading and trailing space from header keys and values before setting the HTTP request header. Fixes a bug when using S3 metadata where metadata values with leading spaces would trigger request signature validation errors when the request is received by the service. V2 SDK port of: aws/aws-sdk-go#2460
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the REST protocol marshaler to trip leading and trailing space from header keys and values before setting the HTTP request header.
Fixes a bug when using S3 metadata where metadata values with leading spaces would trigger request signature validation errors when the request is received by the service.
Fix #2448