This repository was archived by the owner on Jul 31, 2025. It is now read-only.
private/model/api: adding timestampFormat #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jasdel
suggested changes
Jul 19, 2018
| "BlobArgs": { | ||
| "shape": "BlobsType" | ||
| } | ||
| "BlobArgs": { |
| @@ -233,7 +233,14 @@ func (q *queryParser) parseScalar(v url.Values, r reflect.Value, name string, ta | |||
| v.Set(name, strconv.FormatFloat(float64(value), 'f', -1, 32)) | |||
| case time.Time: | |||
| const ISO8601UTC = "2006-01-02T15:04:05Z" | |||
| v.Set(name, value.UTC().Format(ISO8601UTC)) | |||
| // Query ignores "defaultTimestampFormat" as that tag only | |||
| // applies to structured payload body values. | |||
There was a problem hiding this comment.
I don't think this comment is valid anymore
private/protocol/rest/build.go
Outdated
| @@ -272,7 +267,16 @@ func convertType(v reflect.Value, tag reflect.StructTag) (str string, err error) | |||
| case float64: | |||
| str = strconv.FormatFloat(value, 'f', -1, 64) | |||
| case time.Time: | |||
| str = value.UTC().Format(RFC1123GMT) | |||
| // REST ignores "defaultTimestampFormat" as that tag only | |||
| // applies to structured payload body values. | |||
There was a problem hiding this comment.
I don't think this comment is valid anymore
private/protocol/rest/unmarshal.go
Outdated
| @@ -198,7 +198,13 @@ func unmarshalHeader(v reflect.Value, header string, tag reflect.StructTag) erro | |||
| } | |||
| v.Set(reflect.ValueOf(&f)) | |||
| case *time.Time: | |||
| t, err := time.Parse(time.RFC1123, header) | |||
| // REST ignores "defaultTimestampFormat" as that tag only | |||
| // applies to strucutred payload body values. | |||
There was a problem hiding this comment.
I don't think this comment is valid anymore
private/protocol/timestamp.go
Outdated
| case ISO8601TimeFormatName: | ||
| str = t.Format(ISO8601TimeFormat) | ||
| case UnixTimeFormatName: | ||
| str = strconv.FormatInt(t.Unix(), 10) |
There was a problem hiding this comment.
nit would prefer these cases all return their string since the str var isn't being used other than return a value.
jasdel
approved these changes
Jul 19, 2018
xibz
added a commit
to xibz/aws-sdk-go
that referenced
this pull request
Sep 12, 2018
* adding support for timestampFormat * regenerating services * Adding enums back * fixing gofmt
usrenmae
pushed a commit
to usrenmae/aws-sdk-go
that referenced
this pull request
Sep 23, 2018
* adding support for timestampFormat * regenerating services * Adding enums back * fixing gofmt
jasdel
pushed a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Aug 20, 2019
Adds support for the timestampForamt API model trait to the V2 SDK. The SDK will now generate API client parameters with the correct time format for APIs modeled with custom time stamp formats specified. V2 Port of aws/aws-sdk-go#2066 Fix #202 Fix #286
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.