Skip to content
This repository was archived by the owner on Jul 31, 2025. It is now read-only.

internal/ini: adding ini parser #2024

Closed
wants to merge 76 commits into from
Closed

internal/ini: adding ini parser #2024

wants to merge 76 commits into from

Conversation

xibz
Copy link
Contributor

@xibz xibz commented Jul 3, 2018 •
edited
Loading

ini parser uses an LL(1) parser to generate a list of sections from an ini file or bytes.
This change will get rid of a dependency and below is the benchmark data for this change:

BenchmarkINIParser-4              100000             15926 ns/op           13312 B/op         45 allocs/op
BenchmarkGoINIParser-4            200000              7393 ns/op            8528 B/op         65 allocs/op

@xibz xibz requested a review from jasdel July 3, 2018 21:49
@xibz xibz force-pushed the ini branch 5 times, most recently from 817870e to d474896 Compare July 5, 2018 17:06
@jasdel jasdel added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Jul 5, 2018
@xibz xibz force-pushed the ini branch 15 times, most recently from 73dbd7d to c7514f9 Compare July 7, 2018 06:24
@xibz xibz added Review Needed and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 7, 2018
@xibz xibz force-pushed the ini branch 3 times, most recently from babbe53 to 7d526c0 Compare July 8, 2018 09:40
jasdel and others added 23 commits October 11, 2018 13:05
@jasdel @xibz
private/model/api: Correct spelling typo in service API (aws#2178)
2925dde 
Fixes the spelling of "successfully" in the SDK's generate API docs.

Related to: aws#2170
@xibz
Release v1.15.50
c702bfc
@xibz
Release v1.15.51
4d4d5d0
@xibz
Adding ini parser
eb23200
@xibz
Adding support for base numbers
10134a3
@xibz
Adding support for negative values and scientific notation
d2b7af6
@xibz
adding support for escaped strings
031dcd6
@xibz
renaming tables to sections and adding more docs
5551bf0
@xibz
Adding number helper
f98254c
@xibz
fixing parsing bugs
353740b
@xibz
Adding const state names
bc91ff0
@xibz
removing nested section with '[ foo.bar ]' as it is not supported by …
34eb206 
…our shared config
@xibz
Adding array value skipping
b66034b
@xibz
adding documentation
12e729d
@xibz
add support for utf8 characters
e45e23c
@xibz
adding error code for unable to read files
afbbc35
@xibz
Moving and updating based on feedback
b4e9c25
@xibz
moving to root directory
161d814
@xibz
perf test
341b8d1
@xibz
Adding generic token
c212294
@xibz
Generic AST
e2d5de0
@xibz
Updating based on feedback.
0bda570
@xibz
syncing from tip
ad96c19
@xibz xibz closed this Oct 15, 2018
@xibz xibz mentioned this pull request Oct 15, 2018
Merged
@xibz xibz deleted the ini branch October 30, 2018 21:52
@diehlaws diehlaws added needs-review This issue or pull request needs review from a core team member. and removed review-needed labels Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jasdel jasdel jasdel requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xibz @jasdel @diehlaws @atsushi-ishibashi @rogchap