This repository was archived by the owner on Jul 31, 2025. It is now read-only.
aws/endpoints: Use service metadata for fallback signing name #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
fixup/SigningName
branch
from
aff6f21 to
ccc1529
Compare
|
Updated codebase to use a new flag |
jasdel
force-pushed
the
fixup/SigningName
branch
from
ccc1529 to
4423fe2
Compare
|
Any endpoint which is specified by the user via the "Endpoint" config parameter requires the empty signingName check to ensure that the service modeled signing name is used. Needed for services like iot data plane and media store data. |
xibz
approved these changes
Mar 22, 2018
jasdel
added a commit
that referenced
this pull request
Mar 22, 2018
Merged
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
May 25, 2018
Fixes how the SDK derives service signing names. If the signing name is not modeled in the endpoints package the service will fallback to the signing name modeled in the service model. Fix aws#163 Fix aws#153 V2 Port of aws/aws-sdk-go#1854
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
May 25, 2018
Fixes how the SDK derives service signing names. If the signing name is not modeled in the endpoints package the service will fallback to the signing name modeled in the service model. Fix #163 Fix #153 V2 Port of aws/aws-sdk-go#1854
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
May 25, 2018
Services --- * Synced the V2 SDK with latests AWS service API definitions. SDK Bugs --- * `private/protocol/xml/xmlutil`: Fix XML unmarshaler not correctly unmarshaling list of timestamp values ([aws#166](aws#166)) * Fixes a bug in the XML unmarshaler that would incorrectly try to unmarshal "time.Time" parameters that did not have the struct tag type on them. * Related to [aws/aws-sdk-go#1894](aws/aws-sdk-go#1894) * `service/s3`: Fix typos for migrated S3 specific config options ([aws#173](aws#173)) * Updates the S3 specific config error messages to the correct fields. * `aws/endpoints`: Fix SDK endpoint signing name resolution ([aws#181](aws#181)) * Fixes how the SDK derives service signing names. If the signing name is not modeled in the endpoints package the service will fallback to the signing name modeled in the service model. * Fix [aws#163](aws#163) * Fix [aws#153](aws#153) * Related to [aws/aws-sdk-go#1854](aws/aws-sdk-go#1854) * `service/s3`: remove SelectContent until EventStream supported ([aws#175](aws#175]) * S3's SelectContent API is not functional in the SDK yet, and was not supposed to be generated until EventStream support is available. * Related to [aws/aws-sdk-go#1941](aws/aws-sdk-go#1941) SDK Enhancements --- * `service/s3/s3manager/s3manageriface`: Add WithIterator to mock interface ([aws#156](aws#156)) * Updates the `DownloaderAPI` and `UploaderAPI` mocking interfaces to have parity with the concrete types. * Fixes [aws#155](aws#155)
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
May 26, 2018
Services --- * Synced the V2 SDK with latests AWS service API definitions. SDK Bugs --- * `private/protocol/xml/xmlutil`: Fix XML unmarshaler not correctly unmarshaling list of timestamp values ([#166](#166)) * Fixes a bug in the XML unmarshaler that would incorrectly try to unmarshal "time.Time" parameters that did not have the struct tag type on them. * Related to [aws/aws-sdk-go#1894](aws/aws-sdk-go#1894) * `service/s3`: Fix typos for migrated S3 specific config options ([#173](#173)) * Updates the S3 specific config error messages to the correct fields. * `aws/endpoints`: Fix SDK endpoint signing name resolution ([#181](#181)) * Fixes how the SDK derives service signing names. If the signing name is not modeled in the endpoints package the service will fallback to the signing name modeled in the service model. * Fix [#163](#163) * Fix [#153](#153) * Related to [aws/aws-sdk-go#1854](aws/aws-sdk-go#1854) * `service/s3`: remove SelectContent until EventStream supported ([#175](#175]) * S3's SelectContent API is not functional in the SDK yet, and was not supposed to be generated until EventStream support is available. * Related to [aws/aws-sdk-go#1941](aws/aws-sdk-go#1941) SDK Enhancements --- * `service/s3/s3manager/s3manageriface`: Add WithIterator to mock interface ([#156](#156)) * Updates the `DownloaderAPI` and `UploaderAPI` mocking interfaces to have parity with the concrete types. * Fixes [#155](#155)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's endpoint resolution to fallback deriving the service's signing name from the service's modeled metadata in addition the the endpoints modeled data.
Removes the need for customizations such as runtime.sagemaker and CloudHSMv2. (#1751, #1838)
Also removes testify from endpoints decode_test.go.
Fix #1850