Update SigV4 Signer Design #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
reviewed
Dec 9, 2020
There was a problem hiding this comment.
I think we probably want to included the suffix Middleware on the SignHTTPRequest and PresignHTTPRequest types since they are in the same package as the signing and presign implementations. If they were in their own package separate from the Signer/Presigner, and HTTPSigner/HTTPPresigner types then probably wouldn't need the suffix, but since they are together, I can the type names being confusing.
3 tasks
jasdel
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SigV4 signer design to allow for overriding of signer configuration when invoking SignHTTP or PresignHTTP.
Fixes: #917
Fixes: #960
Fixes: #958