Adds support for access-point and outposts for s3 / s3control client #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
suggested changes
Nov 5, 2020
...hy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/EndpointGenerator.java
Outdated
Show resolved
Hide resolved
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3UpdateEndpoint.java
Outdated
Show resolved
Hide resolved
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3UpdateEndpoint.java
Outdated
Show resolved
Hide resolved
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3UpdateEndpoint.java
Outdated
Show resolved
Hide resolved
skmcgrail
reviewed
Nov 5, 2020
skmcgrail
suggested changes
Nov 12, 2020
...hy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/EndpointGenerator.java
Outdated
Show resolved
Hide resolved
...hy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/EndpointGenerator.java
Outdated
Show resolved
Hide resolved
...hy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/EndpointGenerator.java
Show resolved
Hide resolved
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3UpdateEndpoint.java
Outdated
Show resolved
Hide resolved
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3UpdateEndpoint.java
Outdated
Show resolved
Hide resolved
service/s3control/internal/customizations/process_arn_resource.go
Outdated
Show resolved
Hide resolved
service/s3control/internal/customizations/update_endpoint_test.go
Outdated
Show resolved
Hide resolved
…feedback around naming of arn lookup middleware
skmcgrail
suggested changes
Nov 13, 2020
service/s3control/internal/customizations/process_arn_resource.go
Outdated
Show resolved
Hide resolved
jasdel
reviewed
Nov 16, 2020
skmcgrail
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Adds customizations for s3 to support accesspoint and outposts accesspoint arn formats
[x] Adds customizations for s3control to support outposts accesspoint and outposts bucket arn formats