Skip to content

rest-json: updates rest-json error code retriever util #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2020
Merged

rest-json: updates rest-json error code retriever util #837

merged 2 commits into from
Oct 21, 2020

Conversation

skotambkar
Copy link
Contributor

@skotambkar skotambkar commented Oct 20, 2020 •
edited by jasdel
Loading

  • Updates error code getter util to use json.Decoder's decode method directly.
  • Adds tests

Fixes #832

@skotambkar skotambkar requested a review from jasdel October 20, 2020 08:29
jasdel
jasdel reviewed Oct 20, 2020
View reviewed changes
@skotambkar skotambkar merged commit e113848 into master Oct 21, 2020
@skotambkar skotambkar deleted the fix-unexpected-panic branch October 25, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skmcgrail skmcgrail Awaiting requested review from skmcgrail

1 more reviewer

@jasdel jasdel jasdel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unexpected panics instead of errors in >=v0.25.0
2 participants
@skotambkar @jasdel