service/s3: Derive error code, message from HTTP status code for no body/header responses. #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skotambkar
commented
Oct 14, 2020
skotambkar
commented
- Updates s3 xml error util to derive error code, message from HTTP status code if none is found in error response.
- Adds customization integration for S3 HeadObject, that removes all error shapes associated with that operation.
skotambkar
changed the title
S3: Derive error code, message from HTTP status code for no body/header responses.s3: Derive error code, message from HTTP status code for no body/header responses.
jasdel
reviewed
Oct 14, 2020
...ithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsGoDependency.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/aws/go/codegen/customization/AwsCustomGoDependency.java
Outdated
Show resolved
Hide resolved
...main/resources/META-INF/services/software.amazon.smithy.go.codegen.integration.GoIntegration
Show resolved
Hide resolved
skotambkar
force-pushed
the
fix-unknown-error
branch
from
5fb3870 to
24a8806
Compare
jasdel
reviewed
Oct 16, 2020
...thy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/XMLProtocolUtils.java
Outdated
Show resolved
Hide resolved
jasdel
approved these changes
Oct 16, 2020
jasdel
changed the title
s3: Derive error code, message from HTTP status code for no body/header responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.