[Validation] Fix bug that caused unhelpful validation errors in case DevSettings is null, DevSettings/InstanceTypesData is not a valid JSON or it is missing required fields. #7106
+139
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix bugs that caused unhelpful validation error messages in the following cases:
DevSettingsis null.DevSettings/InstanceTypesDatais not a valid JSON.DevSettings/InstanceTypesDatais missing required fields.Before this change the validators where returning cryptic and not actionable error messages such as
'NoneType' object has no attribute 'get'.With this change we moved to more clear an acitonable error messages (See UX description below).
User experience after this change
When
DevSettingsis null:When
DevSetting/InstanceTypesDatais not a valid JSON:When
DevSettings/InstanceTypesDatais missing the required fieldNetworkInfo/NetworkCardsUser Experience before this change
When
DevSettingsis null:When
DevSettings/InstanceTypesDatais not a valid JSON:When
DevSettings/InstanceTypesDatais missing the requiredf fieldNetworkInfo/NetworkCardsTests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.