fix changedir when unpacking tar/tgz #396
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboon
approved these changes
Jun 4, 2024
|
Can confirm this problem is affecting us in production and the proposed patch addresses the issue. Highly recommend 👍 |
|
It is 3+ years and there is still no fully working version for ubuntu 22.04+ (#301) - baffling |
|
It looks like the fix is working, is this ever ganna get release? |
|
Hello, same issue here when I tried to update my instances from debian 11 to debian 12... |
|
Hey can someone approve this? Would be incredibly helpful for my org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
When running multiple deployments with a
tar/tgzbundle on the same host with the same codeagent instance, there is a chance for a race condition at theDownloadBundlestep where it may fail with a variety of error messages (eg):Error extracting tar archive:conflicting chdir during another chdir blockThis change removes the use of
FileUtils.cdwhen spawning thetarcommand in favour for tar's-Coption which sets the changes the directory when running the command. This resolves any contention on the current directory as the directory is changed within each process' respective shells.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.