improve forceConnect pipeline

[sergiyvamz]

Summary

improve forceConnect pipeline:

• review implemented forceConnect() for existing plugins
• keep forceConnect() for plugins related to db authentication; remove forceConnect() for other plugins
• allows to skip a particular plugin while calling connect() or forceConnect() pipeline

Additional Reviewers

@karenc-bq
@aaronchung-bitquill
@aaron-congo

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[github-actions]

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[aaron-congo]

Similar to my previous comment, it seems a bit misleading to label this as an Authentication plugin when it doesn't actually provide auth functionality. Can we similarly either remove this and explicitly check for this plugin in ConnectionPluginManager#makePluginChainFunc or do something like rename AuthenticationConnectionPlugin to ForceConnectPlugin?

[aaron-congo]

Similar to my previous comment, it seems a bit misleading to label this as an Authentication plugin when it doesn't actually provide auth functionality. Can we similarly either remove this and explicitly check for this plugin in ConnectionPluginManager#makePluginChainFunc or do something like rename AuthenticationConnectionPlugin to ForceConnectPlugin

[aaron-congo]

FastestResponseStrategyPlugin and BenchmarkPlugin still have a forceConnect method/implementation but will be excluded from the forceConnect pipeline with these changes. If they should be in the forceConnect pipeline, can we check for them in ConnectionPluginManager#makePluginChainFunc similarly to DefaultConnectionPlugin? And if they should not be in the forceConnect pipeline, can we remove their forceConnect/connectInternal methods?