Update lambda_function.py #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if diff_dates(strUpdate, now) < int(intHours):
This line breaks things, as intHours is in seconds and strUpdate and now are both in epoch time. Even if intHours was in the correct format all this does is make old alerts occur if they're over 24 hours old.
You need a try statement around isItemResponse = response.get('Item'), as if the item isn't in the database it'll throw an error because response.get is invalid for NoneType.
I also fixed an indent error for the last else statement.
Added another else: to the end to log no action events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if diff_dates(strUpdate, now) < int(intHours):
This line breaks things, as intHours is in seconds and strUpdate and now are both in epoch time. Even if intHours was in the correct format all this does is make old alerts occur if they're over 24 hours old.
You need a try statement around isItemResponse = response.get('Item'), as if the item isn't in the database it'll throw an error because response.get is invalid for NoneType.
I also fixed an indent error for the last else statement.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.